fpga: bridge: properly initialize bridge device before populating children
authorAlexis Lothoré <alexis.lothore@bootlin.com>
Tue, 4 Apr 2023 13:31:02 +0000 (15:31 +0200)
committerXu Yilun <yilun.xu@intel.com>
Thu, 6 Apr 2023 16:10:04 +0000 (00:10 +0800)
commitdc70eb868b9cd2ca01313e5a394e6ea001d513e9
treefeacdab4a2e1cbf0728656fb484845254dba86a7
parentd2b727cb532b15e8b33aa259c2e885679618971c
fpga: bridge: properly initialize bridge device before populating children

The current code path can lead to warnings because of uninitialized device,
which contains, as a consequence, uninitialized kobject. The uninitialized
device is passed to of_platform_populate, which will at some point, while
creating child device, try to get a reference on uninitialized parent,
resulting in the following warning:

kobject: '(null)' ((ptrval)): is not initialized, yet kobject_get() is
being called.

The warning is observed after migrating a kernel 5.10.x to 6.1.x.
Reverting commit 0d70af3c2530 ("fpga: bridge: Use standard dev_release for
class driver") seems to remove the warning.
This commit aggregates device_initialize() and device_add() into
device_register() but this new call is done AFTER of_platform_populate

Fixes: 0d70af3c2530 ("fpga: bridge: Use standard dev_release for class driver")
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20230404133102.2837535-2-alexis.lothore@bootlin.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
drivers/fpga/fpga-bridge.c