[PATCH] NFS: Introduce the use of inode->i_lock to protect fields in nfsi
authorChuck Lever <cel@citi.umich.edu>
Thu, 18 Aug 2005 18:24:12 +0000 (11:24 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 18 Aug 2005 19:53:57 +0000 (12:53 -0700)
commitdc59250c6ebed099a9bc0a11298e2281dd896657
tree80c294437c0868d90abfa617d873370e6dbe6565
parent412d582ec1dd59aab2353f8cb7e74f2c79cd20b9
[PATCH] NFS: Introduce the use of inode->i_lock to protect fields in nfsi

Down the road we want to eliminate the use of the global kernel lock entirely
from the NFS client.  To do this, we need to protect the fields in the
nfs_inode structure adequately.  Start by serializing updates to the
"cache_validity" field.

Note this change addresses an SMP hang found by njw@osdl.org, where processes
deadlock because nfs_end_data_update and nfs_revalidate_mapping update the
"cache_validity" field without proper serialization.

Test plan:
 Millions of fsx ops on SMP clients.  Run Nick Wilson's breaknfs program on
 large SMP clients.

Signed-off-by: Chuck Lever <cel@netapp.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/nfs/dir.c
fs/nfs/inode.c
fs/nfs/nfs3acl.c
fs/nfs/read.c
include/linux/nfs_fs.h