[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934)...
authorShane Neuville <shane94@hotmail.com>
Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)
committerRui Marinho <me@ruimarinho.net>
Thu, 18 Apr 2019 15:25:31 +0000 (16:25 +0100)
commitdbf4037a31f411acf6809a77027757fa9b677a81
treed511ada5e1a2c6f20037f7cf358bd08b39f7735d
parentd63002c25f2a8311549eddccd4ddb3f944901b5c
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501

* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes
15 files changed:
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Xamarin.Forms.Controls/ShellContentTest.xaml [moved from Xamarin.Forms.Controls/ShellContent.xaml with 94% similarity]
Xamarin.Forms.Controls/ShellContentTest.xaml.cs [moved from Xamarin.Forms.Controls/ShellContent.xaml.cs with 93% similarity]
Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj
Xamarin.Forms.Core.UnitTests/ShellTests.cs
Xamarin.Forms.Core/BindableObject.cs
Xamarin.Forms.Core/Cells/Cell.cs
Xamarin.Forms.Core/Element.cs
Xamarin.Forms.Core/Shell/BaseShellItem.cs
Xamarin.Forms.Core/Shell/IShellController.cs
Xamarin.Forms.Core/Shell/Shell.cs
Xamarin.Forms.Core/Shell/ShellContent.cs
Xamarin.Forms.Platform.Android/Renderers/ShellItemRenderer.cs
Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs