scsi: message: fusion: Replace all non-returning strlcpy() with strscpy()
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:02:48 +0000 (16:02 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 May 2023 22:03:33 +0000 (18:03 -0400)
commitdbe37c71d1246ec2c5f851aeede12db44ffd5d2c
treebd2cfd66972deae6de67253e7e3b5f243ee1833d
parent4dae0262fb990873adad012dc8338f99cbca8574
scsi: message: fusion: Replace all non-returning strlcpy() with strscpy()

strlcpy() reads the entire source buffer first.  This read may exceed the
destination size limit.  This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1].  In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230530160248.411637-1-azeemshaikh38@gmail.com
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptbase.c
drivers/message/fusion/mptctl.c