sfc: only use fixed-id if the skb asks for it
authorEdward Cree <ecree@solarflare.com>
Wed, 28 Oct 2020 20:43:59 +0000 (20:43 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 31 Oct 2020 00:42:53 +0000 (17:42 -0700)
commitdbe2f251f9eb2158d2c9ec22cc22cc2fc66370e1
tree2b9bde742ca1405354868ae4fd21d57af0890e45
parent806f9f23b6732de81daf3aafae5363bb56d29ed6
sfc: only use fixed-id if the skb asks for it

AIUI, the NETIF_F_TSO_MANGLEID flag is a signal to the stack that a
 driver may _need_ to mangle IDs in order to do TSO, and conversely
 a signal from the stack that the driver is permitted to do so.
Since we support both fixed and incrementing IPIDs, we should rely
 on the SKB_GSO_FIXEDID flag on a per-skb basis, rather than using
 the MANGLEID feature to make all TSOs fixed-id.
Includes other minor cleanups of ef100_make_tso_desc() coding style.

Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/ef100_nic.c
drivers/net/ethernet/sfc/ef100_tx.c