scsi: sg: fix blktrace debugfs entries leakage
authorYu Kuai <yukuai3@huawei.com>
Sat, 10 Jun 2023 02:20:02 +0000 (10:20 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 15 Jun 2023 02:24:03 +0000 (20:24 -0600)
commitdb59133e927916d8a25ee1fd8264f2808040909d
treee7867d42daaafe5d4f41c14caa8bcdff11654882
parentcbe7cff4a76bc749dd70264ca5cf924e2adf9296
scsi: sg: fix blktrace debugfs entries leakage

sg_ioctl() support to enable blktrace, which will create debugfs entries
"/sys/kernel/debug/block/sgx/", however, there is no guarantee that user
will remove these entries through ioctl, and deleting sg device doesn't
cleanup these blktrace entries.

This problem can be fixed by cleanup blktrace while releasing
request_queue, however, it's not a good idea to do this special handling
in common layer just for sg device.

Fix this problem by shutdown bltkrace in sg_device_destroy(), where the
device is deleted and all the users close the device, also grab a
scsi_device reference from sg_add_device() to prevent scsi_device to be
freed before sg_device_destroy();

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20230610022003.2557284-3-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/scsi/sg.c