cachefiles: Drop superfluous readpages aops NULL check
authorTakashi Iwai <tiwai@suse.de>
Wed, 20 Jan 2021 16:11:12 +0000 (16:11 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 20 Jan 2021 19:33:51 +0000 (11:33 -0800)
commitdb58465f1121086b524be80be39d1fedbe5387f3
treebf1499f56ceb9f3652e6baa9994066395addfe29
parent45dfb8a5659ad286c28fa59008271dbc4e5e3f2d
cachefiles: Drop superfluous readpages aops NULL check

After the recent actions to convert readpages aops to readahead, the
NULL checks of readpages aops in cachefiles_read_or_alloc_page() may
hit falsely.  More badly, it's an ASSERT() call, and this panics.

Drop the superfluous NULL checks for fixing this regression.

[DH: Note that cachefiles never actually used readpages, so this check was
 never actually necessary]

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208883
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1175245
Fixes: 9ae326a69004 ("CacheFiles: A cache that backs onto a mounted filesystem")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/cachefiles/rdwr.c