net: arcnet: Remove "#define bool int"
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 2 Jul 2014 12:12:01 +0000 (14:12 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2014 04:34:43 +0000 (21:34 -0700)
commitdb55b62cab8d458aba4e7a81dc4dd98b45c03d85
tree76e595d03ae546c114a0a72ddd233379fa131d27
parenta16a3361927f75e6032df110920c83ca6c5045d3
net: arcnet: Remove "#define bool int"

The header file include/linux/arcdevice.h #defines bool to int, if
bool is not already #defined. However, the files which use that header
file seem to rely on that #define (unconditionally) being in effect:
the prototypes for the functions arcrimi_reset, com20020_reset,
com90io_reset, com90xx_reset (whose addresses are assigned to the
hw.reset member of struct arcnet_local) use int explicitly.

Moreover, that #define is an accident waiting to happen (scenario:
inclusion of arcdevice.h followed by inclusion of some header which
declares function prototypes using bool). Also, #include
<linux/types.h> must appear before #include <linux/arcdevice.h> (the
compiler wouldn't like "typedef _Bool int").

Since none of the files using arcdevice.h declare variables of type
"bool", the patch is actually quite simple, unlike the commit message.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/arcdevice.h