Use f_lock to protect f_flags
authorJonathan Corbet <corbet@lwn.net>
Fri, 6 Feb 2009 22:25:24 +0000 (15:25 -0700)
committerJonathan Corbet <corbet@lwn.net>
Mon, 16 Mar 2009 14:32:27 +0000 (08:32 -0600)
commitdb1dd4d376134eba0e08af523b61cc566a4ea1cd
tree8882c673abbaa5713511b7046493fa862b9140d1
parent684999149002dd046269666a390458e0acb38280
Use f_lock to protect f_flags

Traditionally, changes to struct file->f_flags have been done under BKL
protection, or with no protection at all.  This patch causes all f_flags
changes after file open/creation time to be done under protection of
f_lock.  This allows the removal of some BKL usage and fixes a number of
longstanding (if microscopic) races.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
13 files changed:
drivers/char/tty_io.c
drivers/usb/gadget/file_storage.c
fs/fcntl.c
fs/ioctl.c
fs/nfsd/vfs.c
include/linux/fs.h
ipc/mqueue.c
sound/core/oss/pcm_oss.c
sound/oss/au1550_ac97.c
sound/oss/audio.c
sound/oss/sh_dac_audio.c
sound/oss/swarm_cs4297a.c
sound/oss/vwsnd.c