[ARM] Re-re-apply VLD1/VST1 base-update combine.
authorAhmed Bougacha <ahmed.bougacha@gmail.com>
Thu, 19 Feb 2015 23:52:41 +0000 (23:52 +0000)
committerAhmed Bougacha <ahmed.bougacha@gmail.com>
Thu, 19 Feb 2015 23:52:41 +0000 (23:52 +0000)
commitdb141ac37daf1f643a28ce20e3885fa57f3a165c
treed1d7f08466e43b97a74a1683e71d967dc2c46d18
parent2105ae98f6c84a133e5298cea4e53bd9bebb6ca2
[ARM] Re-re-apply VLD1/VST1 base-update combine.

This re-applies r223862, r224198, r224203, and r224754, which were
reverted in r228129 because they exposed Clang misalignment problems
when self-hosting.

The combine caused the crashes because we turned ISD::LOAD/STORE nodes
to ARMISD::VLD1/VST1_UPD nodes.  When selecting addressing modes, we
were very lax for the former, and only emitted the alignment operand
(as in "[r1:128]") when it was larger than the standard alignment of
the memory type.

However, for ARMISD nodes, we just used the MMO alignment, no matter
what.  In our case, we turned ISD nodes to ARMISD nodes, and this
caused the alignment operands to start being emitted.

And that's how we exposed alignment problems that were ignored before
(but I believe would have been caught with SCTRL.A==1?).

To fix this, we can just mirror the hack done for ISD nodes:  only
take into account the MMO alignment when the access is overaligned.

Original commit message:
We used to only combine intrinsics, and turn them into VLD1_UPD/VST1_UPD
when the base pointer is incremented after the load/store.

We can do the same thing for generic load/stores.

Note that we can only combine the first load/store+adds pair in
a sequence (as might be generated for a v16f32 load for instance),
because other combines turn the base pointer addition chain (each
computing the address of the next load, from the address of the last
load) into independent additions (common base pointer + this load's
offset).

rdar://19717869, rdar://14062261.

llvm-svn: 229932
llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp
llvm/lib/Target/ARM/ARMISelLowering.cpp
llvm/test/CodeGen/ARM/alloc-no-stack-realign.ll
llvm/test/CodeGen/ARM/memcpy-inline.ll
llvm/test/CodeGen/ARM/vector-load.ll [new file with mode: 0644]
llvm/test/CodeGen/ARM/vector-store.ll [new file with mode: 0644]
llvm/test/Transforms/LoopStrengthReduce/ARM/ivchain-ARM.ll