qla2xxx: Fix warning reported by static checker
authorHimanshu Madhani <himanshu.madhani@qlogic.com>
Wed, 20 Jan 2016 23:42:58 +0000 (15:42 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 30 Jan 2016 03:29:59 +0000 (19:29 -0800)
commitdacb58221805bb72ec46a73826c9e59a587d7d68
tree00726c4ecf60ef7064876e56195e780018a39af4
parent8a9ebe717a133ba7bc90b06047f43cc6b8bcb8b3
qla2xxx: Fix warning reported by static checker

This patch fixes following warning

drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
warn: impossible condition '(logged_out == 41) => (0-1 == 41)'

drivers/scsi/qla2xxx/qla_target.c
 3580                  case CTIO_PORT_LOGGED_OUT:
 3581                  case CTIO_PORT_UNAVAILABLE:
 3582                  {
 3583                          bool logged_out = (status & 0xFFFF);
 3584                          ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
 3585                              "qla_target(%d): CTIO with %s status %x "
 3586                              "received (state %x, se_cmd %p)\n", vha->vp_idx,
 3587                              (logged_out == CTIO_PORT_LOGGED_OUT) ?
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                    Bool cannot equal 0x26.
 3588                              "PORT LOGGED OUT" : "PORT UNAVAILABLE",

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/scsi/qla2xxx/qla_target.c