fsnotify: clarify contract for create event hooks
authorAmir Goldstein <amir73il@gmail.com>
Mon, 25 Oct 2021 19:27:18 +0000 (16:27 -0300)
committerJan Kara <jack@suse.cz>
Wed, 27 Oct 2021 10:32:34 +0000 (12:32 +0200)
commitdabe729dddca550446e9cc118c96d1f91703345b
tree9a0768c3fc088a1e2d5a5bca458d16651d52fb10
parentfd5a3ff49a19aa69e2bc1e26e98037c2d778e61a
fsnotify: clarify contract for create event hooks

Clarify argument names and contract for fsnotify_create() and
fsnotify_mkdir() to reflect the anomaly of kernfs, which leaves dentries
negavite after mkdir/create.

Remove the WARN_ON(!inode) in audit code that were added by the Fixes
commit under the wrong assumption that dentries cannot be negative after
mkdir/create.

Fixes: aa93bdc5500c ("fsnotify: use helpers to access data by data_type")
Link: https://lore.kernel.org/linux-fsdevel/87mtp5yz0q.fsf@collabora.com/
Link: https://lore.kernel.org/r/20211025192746.66445-4-krisman@collabora.com
Reviewed-by: Jan Kara <jack@suse.cz>
Reported-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Jan Kara <jack@suse.cz>
include/linux/fsnotify.h
kernel/audit_fsnotify.c
kernel/audit_watch.c