clk: versatile: Add of_node_put() before return statement
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Sat, 29 Aug 2020 17:57:04 +0000 (23:27 +0530)
committerStephen Boyd <sboyd@kernel.org>
Thu, 10 Sep 2020 07:57:42 +0000 (00:57 -0700)
commitda9c43dc0e2ec5c42a3d414e389feb30467000e2
tree67aeb20e55fbb56a94a9f3037695dacb62e8235a
parent73a203b0dc56d2e8d4facc3820b0fcab43a300e1
clk: versatile: Add of_node_put() before return statement

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/versatile/clk-impd1.c