[ios] Shell inset, general SafeArea fixes for shell and non shell embedded pages...
authorShane Neuville <shneuvil@microsoft.com>
Wed, 3 Jul 2019 14:27:51 +0000 (08:27 -0600)
committerGitHub <noreply@github.com>
Wed, 3 Jul 2019 14:27:51 +0000 (08:27 -0600)
commitda8d36df9a9406f21b72b10d10802d24de520b49
tree4c410ce611e2f9f6fc33dc8c92e2e220cfe850d0
parent0a11a184a29ad143d18f8d95ee538cad96d47fdc
[ios] Shell inset,  general SafeArea fixes for shell and non shell embedded pages, entry scrolling fixes (#6457)

* [ios] insets, keyboard scroll, safearea

* ui tests

* small fixes

* ui tests

* additional ui test

* reset default padding more intelligently

* ios10 fixes

* ios10 fixes

* use safe area only if tabbar or navbar is present

* better searching for uiscrollview

* ios11 ui test fixes

* slight delay for scroll to resolve before checking

* Update Xamarin.Forms.Platform.iOS/Renderers/PageRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/KeyboardInsetTracker.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellInsets.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* try to fix ui tests apply pr suggestions

* more app center ios10 tweaks

* ios 10 fixes

* Update Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* PR comments

* fix inset change thrashing and only send offset when changed

* add delay for loading url images and rename shell test

* add null check to extension
19 files changed:
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3809.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4915.xaml
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4915.xaml.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5132.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5239.cs [new file with mode: 0644]
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellInsets.cs [new file with mode: 0644]
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs
Xamarin.Forms.Core.UITests.Shared/Utilities/AppExtensions.cs
Xamarin.Forms.Platform.iOS/Renderers/KeyboardInsetTracker.cs
Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs
Xamarin.Forms.Platform.iOS/Renderers/PageRenderer.cs
Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs
Xamarin.Forms.Platform.iOS/Renderers/ShellPageRendererTracker.cs
Xamarin.Forms.Platform.iOS/Renderers/ShellScrollViewTracker.cs
Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootRenderer.cs
Xamarin.Forms.Platform.iOS/Renderers/TableViewRenderer.cs
Xamarin.Forms.Sandbox.Android/Xamarin.Forms.Sandbox.Android.csproj