drm/vc4: hdmi: Fix HPD GPIO detection
authorMaxime Ripard <maxime@cerno.tech>
Mon, 25 Oct 2021 15:28:55 +0000 (17:28 +0200)
committerDom Cobley <popcornmix@gmail.com>
Mon, 21 Mar 2022 16:03:43 +0000 (16:03 +0000)
commitda6af99230058c9f1429c8eeb845cb6d6021f70a
tree7d5cf64a7f6b973d8cb6d9df7033d4f2ef31f15f
parent3b556c590ba3225878b7c1bf25c080c68d57d6dc
drm/vc4: hdmi: Fix HPD GPIO detection

Prior to commit 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod"), in the
detect hook, if we had an HPD GPIO we would only rely on it and return
whatever state it was in.

However, that commit changed that by mistake to only consider the case
where we have a GPIO and it returns a logical high, and would fall back
to the other methods otherwise.

Since we can read the EDIDs when the HPD signal is low on some displays,
we changed the detection status from disconnected to connected, and we
would ignore an HPD pulse.

Fixes: 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20211025152903.1088803-3-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c