payload buffer datatypes are consistent
authorDavid Fabro <netfilter@meta-dynamic.com>
Thu, 10 Jun 2010 13:03:44 +0000 (15:03 +0200)
committerr.kubiak <r.kubiak@samsung.com>
Mon, 16 Nov 2015 13:12:05 +0000 (14:12 +0100)
commitda3a6e48867e3fe7b63361f35b10329302153a3f
tree638d843052af388d42bdbd9419ed36c10f4c5b66
parentc7fad76eddc9bc7e0e1519ef15693518059aecf0
payload buffer datatypes are consistent

The 'data' parameter to nfq_get_payload() returns pointer to unsigned
char (rather than signed char) to make it consistent with the 'buf'
parameter of nfq_set_verdict(), nfq_set_verdict2(), and
nfq_set_verdict_mark(), all of which refer to the same data.  Either
signed or unsigned is fine, but they should be consistent as the output
of nfq_get_payload() may be passed back into nfq_set_verdict*(); in that
case, this change eliminates the need for typecasting in the calling
code when using compilers that enforce strict typecasting.

Signed-off-by: David Favro <netfilter@meta-dynamic.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/libnetfilter_queue/libnetfilter_queue.h
src/libnetfilter_queue.c
utils/nfqnl_test.c