Don't use the QRegExp methods that modify the object [QtCore]
authorThiago Macieira <thiago.macieira@intel.com>
Fri, 20 Apr 2012 12:59:30 +0000 (14:59 +0200)
committerQt by Nokia <qt-info@nokia.com>
Fri, 27 Apr 2012 20:52:54 +0000 (22:52 +0200)
commitda2c170aa25bc6e8fd6cd0788fae14ee455ce359
treef0e605c55b1d9f32c60a97c03eba909cfbfc012b
parentd78d5ddf2ac5433b09dad2658f810e9de767dfea
Don't use the QRegExp methods that modify the object [QtCore]

QRegExp matching methods modify the object, which we don't want to. In
particular, when we receive a QRegExp from the user or we store in a
context that might require thread-safety, make sure we make a copy
before using it.

QRegularExpression has no such shortcoming.

Task-number: QTBUG-25064
Change-Id: Icf22986cd5f6fd086518c78a7d56e6cadfe9f5f6
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
src/corelib/io/qdiriterator.cpp
src/corelib/kernel/qobject.cpp
src/corelib/mimetypes/qmimeglobpattern.cpp
src/corelib/xml/qxmlutils.cpp