lib/test_bpf: Call page_address() on page acquired with GFP_KERNEL flag
authorSumitra Sharma <sumitraartsy@gmail.com>
Fri, 23 Jun 2023 15:16:44 +0000 (08:16 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 29 Jun 2023 13:32:25 +0000 (15:32 +0200)
commitda1a055d01ed0c18402dd1f1934096ac4bb36ada
tree7f993a1587f1b359b9e81b45d11b3e7eadcd5b6e
parent3a8a670eeeaa40d87bd38a587438952741980c18
lib/test_bpf: Call page_address() on page acquired with GFP_KERNEL flag

generate_test_data() acquires a page with alloc_page(GFP_KERNEL).
The GFP_KERNEL is typical for kernel-internal allocations. The
caller requires ZONE_NORMAL or a lower zone for direct access.

Therefore the page cannot come from ZONE_HIGHMEM. Thus there's no
need to map it with kmap().

Also, the kmap() is being deprecated in favor of kmap_local_page() [1].

Hence, use a plain page_address() directly.

Since the page passed to the page_address() is not from the highmem
zone, the page_address() function will always return a valid kernel
virtual address and will not return NULL. Hence, remove the check
'if (!ptr)'.

Remove the unused variable 'ptr' and label 'err_free_page'.

  [1] https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/

Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://lore.kernel.org/bpf/20230623151644.GA434468@sumitra.com
lib/test_bpf.c