UBIFS: Fix potential integer overflow in allocation
authorSilvio Cesare <silvio.cesare@gmail.com>
Fri, 4 May 2018 03:44:02 +0000 (13:44 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Jul 2018 09:23:14 +0000 (11:23 +0200)
commitda05be555697c3fdd3f1507b59917c1cc3b03566
treec1d49876e8626cc77ae921752b270d7fc78d189b
parentdf15c6eeab46aac3622821e2659677c3eb4abf9d
UBIFS: Fix potential integer overflow in allocation

commit 353748a359f1821ee934afc579cf04572406b420 upstream.

There is potential for the size and len fields in ubifs_data_node to be
too large causing either a negative value for the length fields or an
integer overflow leading to an incorrect memory allocation. Likewise,
when the len field is small, an integer underflow may occur.

Signed-off-by: Silvio Cesare <silvio.cesare@gmail.com>
Fixes: 1e51764a3c2ac ("UBIFS: add new flash file system")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ubifs/journal.c