KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
authorDavid Edmondson <david.edmondson@oracle.com>
Thu, 18 Mar 2021 12:08:37 +0000 (12:08 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 17 Apr 2021 12:30:59 +0000 (08:30 -0400)
commitd9e46d344e62a0d56fd86a8289db5bed8a57c92e
tree4e53bee952764e124c70d133067bd490cc18c754
parentadc2a23734acd607bdf30dc08ba8ffc5ee2a8c9d
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

If the VM entry/exit controls for loading/saving MSR_EFER are either
not available (an older processor or explicitly disabled) or not
used (host and guest values are the same), reading GUEST_IA32_EFER
from the VMCS returns an inaccurate value.

Because of this, in dump_vmcs() don't use GUEST_IA32_EFER to decide
whether to print the PDPTRs - always do so if the fields exist.

Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Message-Id: <20210318120841.133123-2-david.edmondson@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx/vmx.c