ALSA: usb-audio: fix sign unintended sign extension on left shifts
authorColin Ian King <colin.king@canonical.com>
Thu, 27 Jun 2019 16:43:08 +0000 (17:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jul 2019 07:53:42 +0000 (09:53 +0200)
commitd9b6936b134eb95c75274906ad0c1bd78712471d
treed3137b867e9110ab65352cbec7c3ddb3630d0be1
parent7f52af5e9baa9c478edcecdd4058eeef2835b1c3
ALSA: usb-audio: fix sign unintended sign extension on left shifts

commit 2acf5a3e6e9371e63c9e4ff54d84d08f630467a0 upstream.

There are a couple of left shifts of unsigned 8 bit values that
first get promoted to signed ints and hence get sign extended
on the shift if the top bit of the 8 bit values are set. Fix
this by casting the 8 bit values to unsigned ints to stop the
unintentional sign extension.

Addresses-Coverity: ("Unintended sign extension")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/mixer_quirks.c