pinctrl: at91: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 24 Oct 2015 14:42:35 +0000 (16:42 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 27 Oct 2015 16:17:11 +0000 (17:17 +0100)
commitd94b986aa734efea09fbc8f59390ba2e4e00f9d0
tree1e66630b2e7744939a8641e69b3899bedc870a24
parent9d4cc85d290578ec07e37d063d73f0e8707ea3eb
pinctrl: at91: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91.c