small fixes for ping to properly set state in case of failure (dotnet/corefx#33621)
authorTomas Weinfurt <tweinfurt@yahoo.com>
Wed, 13 Mar 2019 16:17:01 +0000 (09:17 -0700)
committerGitHub <noreply@github.com>
Wed, 13 Mar 2019 16:17:01 +0000 (09:17 -0700)
commitd9492c6fc7ce9a802c1bfd8b97eea0f1083e7529
tree156db72f524f5f4850607a61052d7af3d5ec6911
parent95a2c87ae3a61b41617d450949f6137ad05200c9
small fixes for ping to properly set state in case of failure (dotnet/corefx#33621)

* unix ping fixes

* feedback from review and fixes for failing tests

* feedback from review

* more rework on cleanup logic

* add missing check for disposed object in Async path

* remove freebsd part of this change to make it cleaner

* await for all calls of SendPingAsyncCore()

* make arg checking synchronous and stabilize SendPingAsync_InvalidArgs failing on some platforms

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/2696d751a7b50bdc3e03bf5089f67aa0bd081b24
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.Unix.cs
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.Windows.cs
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.cs