[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages
authorDevin Heitmueller <dheitmueller@kernellabs.com>
Fri, 21 Apr 2017 16:28:37 +0000 (13:28 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 10:28:09 +0000 (07:28 -0300)
commitd90b336f3f652ff0441e631a06236f785581c8f7
tree1bee9cc208e1dc6ed7c70c453073cdf3d14cf159
parent682559d9d5bdb986134c891951509ae19068f937
[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages

The recent changes in 4.9 to mandate USB buffers be heap allocated
broke this driver, which was allocating the buffers on the stack.
This resulted in the device failing at initialization.

Introduce dedicated send/receive buffers as part of the state
structure, and add a mutex to protect access to them.

Note: we also had to tweak the API to mxl111sf_ctrl_msg to pass
the pointer to the state struct rather than the device, since
we need it inside the function to access the buffers and the
mutex.  This patch adjusts the callers to match the API change.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Reported-by: Doug Lung <dlung0@gmail.com>
Cc: Michael Ira Krufky <mkrufky@linuxtv.org>
Cc: <stable@vger.kernel.org> # for v4.5 and up
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c
drivers/media/usb/dvb-usb-v2/mxl111sf.c
drivers/media/usb/dvb-usb-v2/mxl111sf.h