ext4: Move mpage_page_done() calls after error handling
authorJan Kara <jack@suse.cz>
Tue, 28 Feb 2023 05:13:18 +0000 (00:13 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 23 Mar 2023 14:06:08 +0000 (10:06 -0400)
commitd8be7607de039e5a477b0a5c63959d81ac052c3b
tree669d041d69e5e33f6f97a1076d8c257978081c5a
parenteaf2ca10ca4ba450f8e514cb8bfc9149660b57f6
ext4: Move mpage_page_done() calls after error handling

In case mpage_submit_page() returns error, it doesn't really matter
whether we call mpage_page_done() and then return error or whether we
return directly because in that case page cleanup will be done by
mpage_release_unused_pages() instead. Logically, it makes more sense to
leave the cleanup to mpage_release_unused_pages() because we didn't
succeed in writing the page. So move mpage_page_done() calls after the
error handling.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Link: https://lore.kernel.org/r/20230228051319.4085470-7-tytso@mit.edu
fs/ext4/inode.c