drm/i915/execlists: Prevent merging requests with conflicting flags
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 11 Oct 2019 19:03:25 +0000 (20:03 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Sat, 12 Oct 2019 06:54:52 +0000 (07:54 +0100)
commitd8ad5f52617b8a74cb3a511d06e24115360761c6
treee6824715527016d5c983c23522743f81bb6da8ff
parenta5efcde69b112d276416f8e6e5e9fd8ede13bfc5
drm/i915/execlists: Prevent merging requests with conflicting flags

We set out-of-bound parameters inside the i915_requests.flags field,
such as disabling preemption or marking the end-of-context. We should
not coalesce consecutive requests if they have differing instructions
as we only inspect the last active request in a context. Thus if we
allow a later request to be merged into the same execution context, it
will mask any of the earlier flags.

References: 2a98f4e65bba ("drm/i915: add infrastructure to hold off preemption on a request")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191011190325.10979-9-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c