2004-05-17 Kristian Høgsberg <krh@redhat.com>
authorKristian Høgsberg <krh@redhat.com>
Mon, 17 May 2004 22:19:04 +0000 (22:19 +0000)
committerKristian Høgsberg <krh@redhat.com>
Mon, 17 May 2004 22:19:04 +0000 (22:19 +0000)
commitd86fc4071ccb8590d922e3456c5c80c0f7bb9d6f
tree7ed880494686d9290ad1f9ded6230459e2e7269a
parent91605d6899e8f21a6adf7f2fc87cfe07d399875f
2004-05-17  Kristian Høgsberg  <krh@redhat.com>

Remove base64 encoding, replace with hex encoding. Original patch
from trow@ximian.com, added error handling.

* dbus/dbus-string.c (_dbus_string_base64_encode)
(_dbus_string_base64_decode): Remove.
(_dbus_string_hex_decode): Add end_return argument so we can
distinguish between OOM and invalid hex encoding.
(_dbus_string_test): Remove base64 tests and add test case for
invalid hex.

* dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
Replace base64 with hex.

* test/data/auth/invalid-hex-encoding.auth-script: New test case
for invalid hex encoded data in auth protocol.
20 files changed:
ChangeLog
dbus/dbus-auth-script.c
dbus/dbus-auth.c
dbus/dbus-errors.c
dbus/dbus-keyring.c
dbus/dbus-string.c
dbus/dbus-string.h
doc/TODO
doc/dbus-specification.xml
doc/dbus-test-plan.xml
test/Makefile.am
test/data/auth/cancel.auth-script
test/data/auth/external-failed.auth-script
test/data/auth/external-root.auth-script
test/data/auth/external-silly.auth-script
test/data/auth/external-successful.auth-script
test/data/auth/extra-bytes.auth-script
test/data/auth/fail-after-n-attempts.auth-script
test/data/auth/invalid-hex-encoding.auth-script [new file with mode: 0644]
test/unbase64.c [deleted file]