scsi: libsas: Do discovery on empty PHY to update PHY info
authorJohn Garry <john.garry@huawei.com>
Fri, 12 Apr 2019 08:57:56 +0000 (16:57 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 15 Apr 2019 22:55:01 +0000 (18:55 -0400)
commitd8649fc1c5e40e691d589ed825998c36a947491c
treeb0cbf9932a4cb53546694e63a02afb858bfb5b5d
parent085f104a83d565097644889bf1f6f1aa6d345cb5
scsi: libsas: Do discovery on empty PHY to update PHY info

When we discover the PHY is empty in sas_rediscover_dev(), the PHY
information (like negotiated linkrate) is not updated.

As such, for a user examining sysfs for that PHY, they would see
incorrect values:

root@(none)$ cd /sys/class/sas_phy/phy-0:0:20
root@(none)$ more negotiated_linkrate
3.0 Gbit
root@(none)$ echo 0 > enable
root@(none)$ more negotiated_linkrate
3.0 Gbit

So fix this, simply discover the PHY again, even though we know it's empty;
in the above example, this gives us:

root@(none)$ more negotiated_linkrate
Phy disabled

We must do this after unregistering the device associated with the PHY
(in sas_unregister_devs_sas_addr()).

Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_expander.c