net: tls, fix sk_write_space NULL write when tx disabled
authorJohn Fastabend <john.fastabend@gmail.com>
Wed, 14 Aug 2019 05:31:54 +0000 (05:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 15 Aug 2019 19:40:15 +0000 (12:40 -0700)
commitd85f01775850a35eae47a0090839baf510c1ef12
tree70da1bd602626134665780205cac31ae15583665
parent6f967f8b1be7001b31c46429f2ee7d275af2190f
net: tls, fix sk_write_space NULL write when tx disabled

The ctx->sk_write_space pointer is only set when TLS tx mode is enabled.
When running without TX mode its a null pointer but we still set the
sk sk_write_space pointer on close().

Fix the close path to only overwrite sk->sk_write_space when the current
pointer is to the tls_write_space function indicating the tls module should
clean it up properly as well.

Reported-by: Hillf Danton <hdanton@sina.com>
Cc: Ying Xue <ying.xue@windriver.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
Fixes: 57c722e932cfb ("net/tls: swap sk_write_space on close")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_main.c