crypto: powerpc - replace memset by memzero_explicit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 30 Nov 2014 17:03:47 +0000 (18:03 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 2 Dec 2014 14:55:50 +0000 (22:55 +0800)
commitd83480b061f95db90bd9df69a21c20d0fd5c9232
treeb9f8d01de0402abde928c0bdb7dc463acb90d3ab
parenta6326ba025a4bc025c8c9a15ea2f307936a93843
crypto: powerpc - replace memset by memzero_explicit

Memset on a local variable may be removed when it is called just before the
variable goes out of scope.  Using memzero_explicit defeats this
optimization.  A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
type T;
@@

{
... when any
T x[...];
... when any
    when exists
- memset
+ memzero_explicit
  (x,
-0,
  ...)
... when != x
    when strict
}
// </smpl>

This change was suggested by Daniel Borkmann <dborkman@redhat.com>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/powerpc/crypto/sha1.c