net: macb: fix use after free on rmmod
authorTong Zhang <ztong0001@gmail.com>
Wed, 8 Sep 2021 19:02:32 +0000 (12:02 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Sep 2021 09:55:44 +0000 (10:55 +0100)
commitd82d5303c4c539db86588ffb5dc5b26c3f1513e8
tree0522461707537a69317c5946ea276aef5aafc29d
parent273c29e944bda9a20a30c26cfc34c9a3f363280b
net: macb: fix use after free on rmmod

plat_dev->dev->platform_data is released by platform_device_unregister(),
use of pclk and hclk is a use-after-free. Since device unregister won't
need a clk device we adjust the function call sequence to fix this issue.

[   31.261225] BUG: KASAN: use-after-free in macb_remove+0x77/0xc6 [macb_pci]
[   31.275563] Freed by task 306:
[   30.276782]  platform_device_release+0x25/0x80

Suggested-by: Nicolas Ferre <Nicolas.Ferre@microchip.com>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb_pci.c