ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
authorJaroslav Kysela <perex@perex.cz>
Fri, 5 May 2023 15:52:38 +0000 (17:52 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 5 May 2023 16:23:48 +0000 (18:23 +0200)
commitd7f5dd9790bbf9c7357672bafb1992ee7aadf45a
treefbf5df90a7a1fb0550b83acb83680a0ddd3b11ea
parent56fc217f0db4fc78e02a1b8450df06389474a5e5
ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"

This reverts commit 9f656705c5faa18afb26d922cfc64f9fd103c38d.

There was a regression (in the top-up mode). Unfortunately, the patch
provided from the author of this commit is not easy to review.

Keep the updated and new comments in headers.
Also add a new comment that documents the missed API constraint which
led to the regression.

Reported-by: Jeff Chua <jeff.chua.linux@gmail.com>
Link: https://lore.kernel.org/r/CAAJw_ZsbTVd3Es373x_wTNDF7RknGhCD0r+NKUSwAO7HpLAkYA@mail.gmail.com
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230505155244.2312199-1-oswald.buddenhagen@gmx.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_lib.c
sound/core/pcm_local.h
sound/core/pcm_native.c