Fix up some nullability annotations to remove unnecessary null-forgiving operations...
authorAhson Khan <ahson_ahmedk@yahoo.com>
Fri, 14 Feb 2020 05:20:36 +0000 (21:20 -0800)
committerGitHub <noreply@github.com>
Fri, 14 Feb 2020 05:20:36 +0000 (21:20 -0800)
commitd7ef909581c0e7aa6e0c40e2e52ad69cc3ccc919
tree7615e9cb9a6b62632f660a8e0ec540fd6546c3dc
parent4c987064cee4d4ba40ba248d2a090ab42d3a92db
Fix up some nullability annotations to remove unnecessary null-forgiving operations (!) (#32186)

* Fix up some nullability annotations to remove unnecessary null-forgiving
operations (!)

* Revert change to TryGetOrAddReferenceOnSerialize since it will never
return null referenceId string.

* Remove unused using directive.

* Adding NotNull on the JsonConverter<T>.Write and MaybeNullWhen on the
OnTryRead method overrides.

* Address feedback - DisallowNull instead of NotNull and remove
comment/debug.assert.

* Add back Debug.Asserts because I like them :)
src/libraries/System.Text.Json/ref/System.Text.Json.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/DictionaryDefaultConverter.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IEnumerableDefaultConverter.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IListConverter.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectDefaultConverter.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/DefaultReferenceResolver.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.HandleMetadata.cs