Remove the QThread::terminated() signal
authorSze Howe Koh <szehowe.koh@gmail.com>
Thu, 18 Oct 2012 16:33:03 +0000 (00:33 +0800)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Fri, 19 Oct 2012 18:25:16 +0000 (20:25 +0200)
commitd7e8b57d0a98696a05cfb0eb15236a34301d9d0a
tree31926a55d022a399ae09eb85ad41a5e369d80215
parent39eaff6773fc4f05fc95473b769b3a2f0301e12b
Remove the QThread::terminated() signal

The signal is removed from the API; all references to it are removed
from documentation; the unit test that checks for its emission is
modified to listen for QThread::finished() instead.

The QThreadPrivate::terminated flag is also removed, as it served no
purpose other than to trigger the emission of QThread::terminated()

As discussed at http://lists.qt-project.org/pipermail/development/2012-October/007216.html
the signal is not guaranteed to be emitted after every termination,
rendering it useless.

Change-Id: I7b0c45d7889da0d33875545331606f2208ee56fc
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
dist/changes-5.0.0
src/corelib/thread/qthread.cpp
src/corelib/thread/qthread.h
src/corelib/thread/qthread_p.h
src/corelib/thread/qthread_unix.cpp
src/corelib/thread/qthread_win.cpp
tests/auto/corelib/thread/qthread/tst_qthread.cpp