btrfs: fix uninitialized parent in insert_state
authorJosef Bacik <josef@toxicpanda.com>
Fri, 18 Nov 2022 20:06:09 +0000 (15:06 -0500)
committerDavid Sterba <dsterba@suse.com>
Mon, 5 Dec 2022 17:00:59 +0000 (18:00 +0100)
commitd7c9e1be2876f63fb2178a24e0c1d5733ff98d47
treeff1b5e3d1d7c77c9be741372dcf083c25e05f2de
parenta4c853af0c511d7e0f7cb306bbc8a4f1dbdb64ca
btrfs: fix uninitialized parent in insert_state

I don't know how this isn't caught when we build this in the kernel, but
while syncing extent-io-tree.c into btrfs-progs I got an error because
parent could potentially be uninitialized when we link in a new node,
specifically when the extent_io_tree is empty.  This means we could have
garbage in the parent color.  I don't know what the ramifications are of
that, but it's probably not great, so fix this by initializing parent to
NULL.  I spot checked all of our other usages in btrfs and we appear to
be doing the correct thing everywhere else.

Fixes: c7e118cf98c7 ("btrfs: open code rbtree search in insert_state")
CC: stable@vger.kernel.org # 6.0+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c