media: v4l2-core: Fix a potential resource leak in v4l2_fwnode_parse_link()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 14 Jun 2023 18:31:05 +0000 (20:31 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 14 Jul 2023 11:20:31 +0000 (13:20 +0200)
commitd7b13edd4cb4bfa335b6008ab867ac28582d3e5c
tree0928717bca1c45f0113b021108383563a52b61c7
parent6363db1c9d45a54ddc1582423b74b5f9935b5958
media: v4l2-core: Fix a potential resource leak in v4l2_fwnode_parse_link()

If fwnode_graph_get_remote_endpoint() fails, 'fwnode' is known to be NULL,
so fwnode_handle_put() is a no-op.

Release the reference taken from a previous fwnode_graph_get_port_parent()
call instead.

Also handle fwnode_graph_get_port_parent() failures.

In order to fix these issues, add an error handling path to the function
and the needed gotos.

Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/v4l2-core/v4l2-fwnode.c