test: remove unnecessary assignments
authorRich Trott <rtrott@gmail.com>
Thu, 24 Dec 2015 00:02:12 +0000 (16:02 -0800)
committerMyles Borins <mborins@us.ibm.com>
Tue, 19 Jan 2016 19:52:30 +0000 (11:52 -0800)
commitd7953010256b09a930869039e6dea36f672679e1
tree5a94e07c94123e1cd79c44718fc136f869983549
parent41882e4077f5938c9b969024f4a73581496c0d83
test: remove unnecessary assignments

common.js needs to be loaded in all tests so that there is checking
for variable leaks and possibly other things. However, it does not
need to be assigned to a variable if nothing in common.js is referred
to elsewhere in the test.

The main tradeoff for this bit of code churn is that it gets the code
base most of the way to being able to enable the no-unused-vars rule in
eslint.

(The non-tooling benefit is that it lessens cognitive load when reading
tests as it is an immediate indication that none of the functions or
properties in common.js will be used by the test.)

PR-URL: https://github.com/nodejs/node/pull/4563
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
307 files changed:
test/internet/test-dns-txt-sigsegv.js
test/internet/test-dns.js
test/internet/test-http-dns-fail.js
test/internet/test-net-connect-timeout.js
test/internet/test-net-connect-unref.js
test/message/2100bytes.js
test/message/core_line_numbers.js
test/message/error_exit.js
test/message/eval_messages.js
test/message/hello_world.js
test/message/max_tick_depth.js
test/message/nexttick_throw.js
test/message/stack_overflow.js
test/message/stdin_messages.js
test/message/throw_custom_error.js
test/message/throw_in_line_with_tabs.js
test/message/throw_non_error.js
test/message/throw_null.js
test/message/throw_undefined.js
test/message/timeout_throw.js
test/message/undefined_reference_in_new_context.js
test/message/vm_display_runtime_error.js
test/message/vm_dont_display_syntax_error.js
test/parallel/test-async-wrap-throw-no-init.js
test/parallel/test-buffer-arraybuffer.js
test/parallel/test-buffer-ascii.js
test/parallel/test-buffer-bytelength.js
test/parallel/test-buffer-concat.js
test/parallel/test-buffer-fakes.js
test/parallel/test-buffer-indexof.js
test/parallel/test-buffer-inheritance.js
test/parallel/test-buffer-inspect.js
test/parallel/test-buffer-iterator.js
test/parallel/test-buffer-slow.js
test/parallel/test-child-process-constructor.js
test/parallel/test-child-process-detached.js
test/parallel/test-child-process-fork-and-spawn.js
test/parallel/test-child-process-fork-ref.js
test/parallel/test-child-process-fork-ref2.js
test/parallel/test-child-process-internal.js
test/parallel/test-child-process-set-blocking.js
test/parallel/test-child-process-silent.js
test/parallel/test-child-process-spawnsync-env.js
test/parallel/test-child-process-spawnsync-timeout.js
test/parallel/test-child-process-stdin-ipc.js
test/parallel/test-child-process-stdio-big-write-end.js
test/parallel/test-child-process-validate-stdio.js
test/parallel/test-cluster-debug-port.js
test/parallel/test-cluster-fork-env.js
test/parallel/test-cluster-setup-master-cumulative.js
test/parallel/test-cluster-setup-master-emit.js
test/parallel/test-cluster-setup-master-multiple.js
test/parallel/test-cluster-setup-master.js
test/parallel/test-cluster-uncaught-exception.js
test/parallel/test-cluster-worker-constructor.js
test/parallel/test-cluster-worker-death.js
test/parallel/test-cluster-worker-init.js
test/parallel/test-console-instance.js
test/parallel/test-console-not-call-toString.js
test/parallel/test-console.js
test/parallel/test-delayed-require.js
test/parallel/test-dgram-bind.js
test/parallel/test-dgram-bytes-length.js
test/parallel/test-dgram-listen-after-bind.js
test/parallel/test-dgram-ref.js
test/parallel/test-dgram-regress-4496.js
test/parallel/test-dgram-send-bad-arguments.js
test/parallel/test-dgram-unref.js
test/parallel/test-dh-padding.js
test/parallel/test-dns-cares-domains.js
test/parallel/test-dns-lookup-cb-error.js
test/parallel/test-dns-regress-7070.js
test/parallel/test-dns.js
test/parallel/test-domain-exit-dispose.js
test/parallel/test-domain-from-timer.js
test/parallel/test-domain-implicit-fs.js
test/parallel/test-domain-nested-throw.js
test/parallel/test-domain-stack.js
test/parallel/test-domain-timers.js
test/parallel/test-domain-top-level-error-handler-throw.js
test/parallel/test-domain.js
test/parallel/test-event-emitter-add-listeners.js
test/parallel/test-event-emitter-check-listener-leaks.js
test/parallel/test-event-emitter-get-max-listeners.js
test/parallel/test-event-emitter-listener-count.js
test/parallel/test-event-emitter-listeners-side-effects.js
test/parallel/test-event-emitter-listeners.js
test/parallel/test-event-emitter-max-listeners.js
test/parallel/test-event-emitter-method-names.js
test/parallel/test-event-emitter-modify-in-emit.js
test/parallel/test-event-emitter-no-error-provided-to-error-event.js
test/parallel/test-event-emitter-num-args.js
test/parallel/test-event-emitter-once.js
test/parallel/test-event-emitter-set-max-listeners-side-effects.js
test/parallel/test-event-emitter-subclass.js
test/parallel/test-exception-handler.js
test/parallel/test-exception-handler2.js
test/parallel/test-exec-max-buffer.js
test/parallel/test-fs-exists.js
test/parallel/test-fs-make-callback.js
test/parallel/test-fs-open-flags.js
test/parallel/test-fs-open.js
test/parallel/test-fs-read-file-sync-hostname.js
test/parallel/test-fs-readfile-zero-byte-liar.js
test/parallel/test-fs-stat.js
test/parallel/test-fs-sync-fd-leak.js
test/parallel/test-fs-write-no-fd.js
test/parallel/test-handle-wrap-close-abort.js
test/parallel/test-http-agent-false.js
test/parallel/test-http-agent-getname.js
test/parallel/test-http-client-readable.js
test/parallel/test-http-methods.js
test/parallel/test-http-parser-bad-ref.js
test/parallel/test-http-parser.js
test/parallel/test-http-url.parse-only-support-http-https-protocol.js
test/parallel/test-internal-modules-expose.js
test/parallel/test-internal-modules.js
test/parallel/test-intl.js
test/parallel/test-js-stream-call-properties.js
test/parallel/test-memory-usage.js
test/parallel/test-microtask-queue-integration-domain.js
test/parallel/test-microtask-queue-integration.js
test/parallel/test-microtask-queue-run-domain.js
test/parallel/test-microtask-queue-run-immediate-domain.js
test/parallel/test-microtask-queue-run-immediate.js
test/parallel/test-microtask-queue-run.js
test/parallel/test-module-loading-error.js
test/parallel/test-net-dns-error.js
test/parallel/test-net-end-without-connect.js
test/parallel/test-net-isip.js
test/parallel/test-net-listen-error.js
test/parallel/test-net-server-connections.js
test/parallel/test-net-server-unref-persistent.js
test/parallel/test-next-tick-domain.js
test/parallel/test-next-tick-errors.js
test/parallel/test-next-tick-intentional-starvation.js
test/parallel/test-next-tick-ordering.js
test/parallel/test-next-tick-ordering2.js
test/parallel/test-next-tick.js
test/parallel/test-path-zero-length-strings.js
test/parallel/test-pipe-return-val.js
test/parallel/test-preload.js
test/parallel/test-process-before-exit.js
test/parallel/test-process-config.js
test/parallel/test-process-env.js
test/parallel/test-process-exit-code.js
test/parallel/test-process-exit.js
test/parallel/test-process-getgroups.js
test/parallel/test-process-hrtime.js
test/parallel/test-process-kill-null.js
test/parallel/test-process-kill-pid.js
test/parallel/test-process-next-tick.js
test/parallel/test-process-raw-debug.js
test/parallel/test-process-wrap.js
test/parallel/test-punycode.js
test/parallel/test-querystring-multichar-separator.js
test/parallel/test-querystring.js
test/parallel/test-readdouble.js
test/parallel/test-readfloat.js
test/parallel/test-readint.js
test/parallel/test-readuint.js
test/parallel/test-ref-unref-return.js
test/parallel/test-regress-GH-6235.js
test/parallel/test-regress-GH-7511.js
test/parallel/test-regress-GH-897.js
test/parallel/test-repl-envvars.js
test/parallel/test-repl-harmony.js
test/parallel/test-repl-require-cache.js
test/parallel/test-repl-setprompt.js
test/parallel/test-repl-syntax-error-handling.js
test/parallel/test-repl-unexpected-token-recoverable.js
test/parallel/test-require-cache.js
test/parallel/test-signal-safety.js
test/parallel/test-stdin-hang.js
test/parallel/test-stdio-readable-writable.js
test/parallel/test-stdout-close-unref.js
test/parallel/test-stream-big-packet.js
test/parallel/test-stream-big-push.js
test/parallel/test-stream-duplex.js
test/parallel/test-stream-end-paused.js
test/parallel/test-stream-ispaused.js
test/parallel/test-stream-pipe-after-end.js
test/parallel/test-stream-pipe-cleanup.js
test/parallel/test-stream-pipe-error-handling.js
test/parallel/test-stream-pipe-event.js
test/parallel/test-stream-push-order.js
test/parallel/test-stream-push-strings.js
test/parallel/test-stream-readable-constructor-set-methods.js
test/parallel/test-stream-readable-event.js
test/parallel/test-stream-readable-flow-recursion.js
test/parallel/test-stream-transform-constructor-set-methods.js
test/parallel/test-stream-transform-objectmode-falsey-value.js
test/parallel/test-stream-transform-split-objectmode.js
test/parallel/test-stream-unshift-empty-chunk.js
test/parallel/test-stream-unshift-read-race.js
test/parallel/test-stream-wrap.js
test/parallel/test-stream-writable-change-default-encoding.js
test/parallel/test-stream-writable-constructor-set-methods.js
test/parallel/test-stream-writable-decoded-encoding.js
test/parallel/test-stream-writev.js
test/parallel/test-stream2-base64-single-char-read-end.js
test/parallel/test-stream2-compatibility.js
test/parallel/test-stream2-finish-pipe.js
test/parallel/test-stream2-large-read-stall.js
test/parallel/test-stream2-objects.js
test/parallel/test-stream2-pipe-error-handling.js
test/parallel/test-stream2-pipe-error-once-listener.js
test/parallel/test-stream2-push.js
test/parallel/test-stream2-read-sync-stack.js
test/parallel/test-stream2-readable-empty-buffer-no-eof.js
test/parallel/test-stream2-readable-from-list.js
test/parallel/test-stream2-readable-legacy-drain.js
test/parallel/test-stream2-readable-non-empty-end.js
test/parallel/test-stream2-readable-wrap-empty.js
test/parallel/test-stream2-readable-wrap.js
test/parallel/test-stream2-set-encoding.js
test/parallel/test-stream2-transform.js
test/parallel/test-stream2-unpipe-leak.js
test/parallel/test-stream2-writable.js
test/parallel/test-stream3-pause-then-read.js
test/parallel/test-string-decoder.js
test/parallel/test-stringbytes-external.js
test/parallel/test-timers-active.js
test/parallel/test-timers-args.js
test/parallel/test-timers-immediate-queue.js
test/parallel/test-timers-immediate.js
test/parallel/test-timers-linked-list.js
test/parallel/test-timers-now.js
test/parallel/test-timers-ordering.js
test/parallel/test-timers-uncaught-exception.js
test/parallel/test-timers-unref-active.js
test/parallel/test-timers-unref-call.js
test/parallel/test-timers-unref-remove-other-unref-timers-only-one-fires.js
test/parallel/test-timers-unref.js
test/parallel/test-timers-zero-timeout.js
test/parallel/test-timers.js
test/parallel/test-tls-parse-cert-string.js
test/parallel/test-tty-stdout-end.js
test/parallel/test-tty-wrap.js
test/parallel/test-url.js
test/parallel/test-utf8-scripts.js
test/parallel/test-util-format.js
test/parallel/test-util-inspect.js
test/parallel/test-util.js
test/parallel/test-v8-flag-type-check.js
test/parallel/test-v8-flags.js
test/parallel/test-v8-stats.js
test/parallel/test-vm-basic.js
test/parallel/test-vm-context-async-script.js
test/parallel/test-vm-context-property-forwarding.js
test/parallel/test-vm-context.js
test/parallel/test-vm-create-and-run-in-context.js
test/parallel/test-vm-create-context-accessors.js
test/parallel/test-vm-create-context-arg.js
test/parallel/test-vm-create-context-circular-reference.js
test/parallel/test-vm-cross-context.js
test/parallel/test-vm-function-declaration.js
test/parallel/test-vm-global-define-property.js
test/parallel/test-vm-global-identity.js
test/parallel/test-vm-harmony-proxies.js
test/parallel/test-vm-harmony-symbols.js
test/parallel/test-vm-is-context.js
test/parallel/test-vm-preserves-property.js
test/parallel/test-vm-symbols.js
test/parallel/test-vm-syntax-error-message.js
test/parallel/test-vm-timeout.js
test/parallel/test-writedouble.js
test/parallel/test-writefloat.js
test/parallel/test-writeint.js
test/parallel/test-writeuint.js
test/parallel/test-zlib-close-after-write.js
test/parallel/test-zlib-const.js
test/parallel/test-zlib-convenience-methods.js
test/parallel/test-zlib-dictionary.js
test/parallel/test-zlib-flush-drain.js
test/parallel/test-zlib-from-string.js
test/parallel/test-zlib-invalid-input.js
test/parallel/test-zlib-write-after-close.js
test/parallel/test-zlib-write-after-flush.js
test/parallel/test-zlib-zero-byte.js
test/pummel/test-dtrace-jsstack.js
test/pummel/test-next-tick-infinite-calls.js
test/pummel/test-process-hrtime.js
test/pummel/test-process-uptime.js
test/pummel/test-stream-pipe-multi.js
test/pummel/test-stream2-basic.js
test/pummel/test-timer-wrap.js
test/pummel/test-timer-wrap2.js
test/pummel/test-timers.js
test/pummel/test-vm-memleak.js
test/sequential/test-debug-args.js
test/sequential/test-deprecation-flags.js
test/sequential/test-memory-usage-emfile.js
test/sequential/test-net-listen-exclusive-random-ports.js
test/sequential/test-regress-GH-1726.js
test/sequential/test-regress-GH-819.js
test/sequential/test-setproctitle.js
test/sequential/test-sigint-infinite-loop.js
test/sequential/test-stdin-child-proc.js
test/sequential/test-stdin-pipe-resume.js
test/sequential/test-stdin-script-child.js
test/sequential/test-stdout-cannot-be-closed-child-process-pipe.js
test/sequential/test-stdout-stderr-reading.js
test/sequential/test-stream2-stderr-sync.js
test/sequential/test-sync-fileread.js
test/sequential/test-util-debug.js
test/timers/test-timers-reliability.js