xsk: Fix unaligned descriptor validation
authorKal Conley <kal.conley@dectris.com>
Wed, 5 Apr 2023 23:59:18 +0000 (01:59 +0200)
committerMartin KaFai Lau <martin.lau@kernel.org>
Thu, 6 Apr 2023 16:53:05 +0000 (09:53 -0700)
commitd769ccaf957fe7391f357c0a923de71f594b8a2b
tree04219cbe7264763a0b64b51f1db796069fbf7386
parent34bf93472f8fb60b4189aa2872471017e739cf0a
xsk: Fix unaligned descriptor validation

Make sure unaligned descriptors that straddle the end of the UMEM are
considered invalid. Currently, descriptor validation is broken for
zero-copy mode which only checks descriptors at page granularity.
For example, descriptors in zero-copy mode that overrun the end of the
UMEM but not a page boundary are (incorrectly) considered valid. The
UMEM boundary check needs to happen before the page boundary and
contiguity checks in xp_desc_crosses_non_contig_pg(). Do this check in
xp_unaligned_validate_desc() instead like xp_check_unaligned() already
does.

Fixes: 2b43470add8c ("xsk: Introduce AF_XDP buffer allocation API")
Signed-off-by: Kal Conley <kal.conley@dectris.com>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/r/20230405235920.7305-2-kal.conley@dectris.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
include/net/xsk_buff_pool.h
net/xdp/xsk_queue.h