projects / platform / upstream / coreutils.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a892af0) | patch
tac: avoid segfault for e.g., "echo > x; tac -r x x"
authorJim Meyering <meyering@redhat.com>
Sun, 4 May 2008 22:07:08 +0000 (00:07 +0200)
committerJim Meyering <meyering@redhat.com>
Mon, 5 May 2008 11:15:32 +0000 (13:15 +0200)
commitd701f6abb73e36721de5df083df4769786a14528
tree59a55d0b47021f52683d2ef97de03ff2258baecbtree | snapshot
parenta892af0d48b47a445fda12a1e889f1a7f3cd5907commit | diff
tac: avoid segfault for e.g., "echo > x; tac -r x x"

* src/tac.c (tac_seekable): Move local "regs" declaration out
to file scope, so its values aren't clobbered between calls.
Discovered by Cristian Cadar, Daniel Dunbar and Dawson Engler,
reported in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13501
* NEWS: Mention the bug fix.
* tests/Makefile.am (TESTS): Add misc/tac.
* tests/misc/tac: New file.  Test for the above.
NEWS diff | blob | history
src/tac.c diff | blob | history
tests/Makefile.am diff | blob | history
tests/misc/tac [new file with mode: 0644] blob
Domain: System / Uncategorized;