libbpf: Revert poisoning of strlcpy
authorJesus Sanchez-Palencia <jesussanp@google.com>
Thu, 9 Mar 2023 00:48:36 +0000 (16:48 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 10 Mar 2023 18:19:25 +0000 (10:19 -0800)
commitd6f7ff9dd387861fa30cbc6375d15b586da17d33
tree39726371b2de880d507e7d80d24503ebb432f685
parentbced3f7db95ff2e6ca29dc4d1c9751ab5e736a09
libbpf: Revert poisoning of strlcpy

This reverts commit 6d0c4b11e743("libbpf: Poison strlcpy()").

It added the pragma poison directive to libbpf_internal.h to protect
against accidental usage of strlcpy but ended up breaking the build for
toolchains based on libcs which provide the strlcpy() declaration from
string.h (e.g. uClibc-ng). The include order which causes the issue is:

    string.h,
    from Iibbpf_common.h:12,
    from libbpf.h:20,
    from libbpf_internal.h:26,
    from strset.c:9:

Fixes: 6d0c4b11e743 ("libbpf: Poison strlcpy()")
Signed-off-by: Jesus Sanchez-Palencia <jesussanp@google.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230309004836.2808610-1-jesussanp@google.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/lib/bpf/libbpf_internal.h