leds: blinkm: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 23 May 2023 02:12:28 +0000 (02:12 +0000)
committerLee Jones <lee@kernel.org>
Thu, 25 May 2023 11:31:18 +0000 (12:31 +0100)
commitd6e3896b7c22278c6f4a9b166211fdddf1c86c3a
tree10ee779beaf97db50041dde9617705b53815a0c0
parent0113cea8fd729ea6187e8d330f74a7e2a73bd970
leds: blinkm: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230523021228.2406112-1-azeemshaikh38@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-blinkm.c