selinux: set next pointer before attaching to list
authorChristian Göttsche <cgzones@googlemail.com>
Fri, 18 Aug 2023 15:33:58 +0000 (17:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2023 14:11:07 +0000 (16:11 +0200)
commitd6b64d710e9bcaa22fa99fdc1cb32e19a0eb5b38
tree1ee76d220325409bb10a894b72b75607b015da61
parent36c5aecc789d4f881d18e6a8f4539636e11ab85e
selinux: set next pointer before attaching to list

commit 70d91dc9b2ac91327d0eefd86163abc3548effa6 upstream.

Set the next pointer in filename_trans_read_helper() before attaching
the new node under construction to the list, otherwise garbage would be
dereferenced on subsequent failure during cleanup in the out goto label.

Cc: <stable@vger.kernel.org>
Fixes: 430059024389 ("selinux: implement new format of filename transitions")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/selinux/ss/policydb.c