projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f92aee7) | patch
build,win: fix node.exe resource version
authorJoão Reis <reis@janeasystems.com>
Wed, 23 Sep 2015 12:33:09 +0000 (13:33 +0100)
committerRod Vagg <rod@vagg.org>
Fri, 2 Oct 2015 03:39:25 +0000 (13:39 +1000)
commitd6ac547d5db149aafa617c75080798fbab00814b
tree397097ac76b2efc12620ae04998d93b90d7c8d52tree | snapshot
parentf92aee717085a8ed6c0ae16d64cd1b92de4382a4commit | diff
build,win: fix node.exe resource version

When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.

Fixes: https://github.com/nodejs/node/issues/2963
PR-URL: https://github.com/nodejs/node/pull/3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
src/node_version.h diff | blob | history
src/res/node.rc diff | blob | history
Domain: Web Framework / Common;