bnx2x: byte swap rss_key to comply to Toeplitz specs
authorEric Dumazet <edumazet@google.com>
Wed, 23 Sep 2015 00:04:58 +0000 (17:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Sep 2015 21:34:49 +0000 (14:34 -0700)
commitd682d2bdc30650a5c7ce9908ab83ab674b658744
treeb66b01751c685ced81f9fa81a510750c067d4cdd
parentd8aecb10115497f6cdf841df8c88ebb3ba25fa28
bnx2x: byte swap rss_key to comply to Toeplitz specs

After a good amount of debugging, I found bnx2x was byte swaping
the 40 bytes of rss_key.

If we byte swap the key, then bnx2x generates hashes matching
MSDN specs as documented in (Verifying the RSS Hash Calculation)

https://msdn.microsoft.com/en-us/library/windows/hardware/ff571021%
28v=vs.85%29.aspx

It is mostly a non issue, unless we want to mix different NIC
in a host, and want consistent hashing among all of them, ie
if they all use the boot time generated rss key, or if some application
is choosing specific tuple(s) so that incoming traffic lands into known
rx queue(s).

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c