[libc++] [P0919] Some belated review on D87171.
authorArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Tue, 31 Aug 2021 17:04:29 +0000 (13:04 -0400)
committerArthur O'Dwyer <arthur.j.odwyer@gmail.com>
Mon, 20 Sep 2021 18:46:38 +0000 (14:46 -0400)
commitd5db71d19f11d7c31257066aea6bd41ef04f28b7
tree8c16d2d3042eade3a7905362dbfe7dadaa6ae0cc
parentdf81bb71aa452c677984fbeb7c34e8a77ec3e83b
[libc++] [P0919] Some belated review on D87171.

- Simplify the structure of the new tests.
- Test const containers as well as non-const containers,
    since it's easy to do so.
- Remove redundant enable-iffing of helper structs' member functions.
    (They're not instantiated unless they're called, and who would call them?)
- Fix indentation and use more consistent SFINAE method in <unordered_map>.
- Add _LIBCPP_INLINE_VISIBILITY on some swap functions.

Differential Revision: https://reviews.llvm.org/D109011
29 files changed:
libcxx/include/map
libcxx/include/unordered_map
libcxx/include/unordered_set
libcxx/test/std/containers/unord/unord.map/contains.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.map/count.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.map/equal_range.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.map/equal_range_non_const.transparent.pass.cpp with 53% similarity]
libcxx/test/std/containers/unord/unord.map/equal_range_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.map/find.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.map/find_non_const.transparent.pass.cpp with 53% similarity]
libcxx/test/std/containers/unord/unord.map/find_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.multimap/contains.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.multimap/count.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.multimap/equal_range.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.multimap/equal_range_non_const.transparent.pass.cpp with 51% similarity]
libcxx/test/std/containers/unord/unord.multimap/equal_range_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.multimap/find.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.multimap/find_non_const.transparent.pass.cpp with 52% similarity]
libcxx/test/std/containers/unord/unord.multimap/find_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.multiset/contains.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.multiset/count.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.multiset/equal_range.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.set/equal_range_const.transparent.pass.cpp with 53% similarity]
libcxx/test/std/containers/unord/unord.multiset/equal_range_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.multiset/equal_range_non_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.multiset/find.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.multiset/find_non_const.transparent.pass.cpp with 53% similarity]
libcxx/test/std/containers/unord/unord.multiset/find_const.transparent.pass.cpp [deleted file]
libcxx/test/std/containers/unord/unord.set/contains.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.set/count.transparent.pass.cpp
libcxx/test/std/containers/unord/unord.set/equal_range.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.set/equal_range_non_const.transparent.pass.cpp with 55% similarity]
libcxx/test/std/containers/unord/unord.set/find.transparent.pass.cpp [moved from libcxx/test/std/containers/unord/unord.set/find_non_const.transparent.pass.cpp with 55% similarity]
libcxx/test/std/containers/unord/unord.set/find_const.transparent.pass.cpp [deleted file]
libcxx/test/support/is_transparent.h
libcxx/test/support/test_transparent_unordered.h