usb: xhci: reset endpoint on USB stall
authorStefan Agner <stefan@agner.ch>
Mon, 27 Sep 2021 12:42:58 +0000 (14:42 +0200)
committerMarek Vasut <marex@denx.de>
Wed, 16 Feb 2022 16:11:31 +0000 (17:11 +0100)
commitd5daa02d8d9e7c403a3339db1966e8413e64e408
tree0a9cb49242da3eb315b4e459cb474c47a911b028
parentfb146fbc1ae551ce3bdb2966dd36a0b38e62b5dc
usb: xhci: reset endpoint on USB stall

There are devices which cause a USB stall when trying to read strings.
Specifically Arduino Mega R3 stalls when trying to read the product
string.

The stall currently remains unhandled, and subsequent retries submit new
transfers on a stopped endpoint which ultimately cause a crash in
abort_td():
WARN halted endpoint, queueing URB anyway.
XHCI control transfer timed out, aborting...
Unexpected XHCI event TRB, skipping... (3affe040 00000000 13000000 02008401)
BUG at drivers/usb/host/xhci-ring.c:505/abort_td()!
BUG!
resetting ...

Linux seems to be able to recover from the stall by issuing a
TRB_RESET_EP command.

Introduce reset_ep() which issues a TRB_RESET_EP followed by setting the
transfer ring dequeue pointer via TRB_SET_DEQ. This allows to properly
recover from a USB stall error and continue communicating with the USB
device.

Signed-off-by: Stefan Agner <stefan@agner.ch>
drivers/usb/host/xhci-ring.c