btrfs: zoned: fix API misuse of zone finish waiting
authorNaohiro Aota <naohiro.aota@wdc.com>
Wed, 31 Aug 2022 04:55:48 +0000 (13:55 +0900)
committerDavid Sterba <dsterba@suse.com>
Mon, 5 Sep 2022 13:32:21 +0000 (15:32 +0200)
commitd5b81ced74afded85619ffbbe9c32ba9d82c9b1e
tree69a37c31e1956ef64754541e9356e1ee41a1fe81
parentf2c3bec215694fb8bc0ef5010f2a758d1906fc2d
btrfs: zoned: fix API misuse of zone finish waiting

The commit 2ce543f47843 ("btrfs: zoned: wait until zone is finished when
allocation didn't progress") implemented a zone finish waiting mechanism
to the write path of zoned mode. However, using
wait_var_event()/wake_up_all() on fs_info->zone_finish_wait is wrong and
wait_var_event() just hangs because no one ever wakes it up once it goes
into sleep.

Instead, we can simply use wait_on_bit_io() and clear_and_wake_up_bit()
on fs_info->flags with a proper barrier installed.

Fixes: 2ce543f47843 ("btrfs: zoned: wait until zone is finished when allocation didn't progress")
CC: stable@vger.kernel.org # 5.16+
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.h
fs/btrfs/disk-io.c
fs/btrfs/inode.c
fs/btrfs/zoned.c