leds: lm3533: fix use-after-free on unbind
authorJohan Hovold <johan@kernel.org>
Mon, 1 Jun 2020 13:39:47 +0000 (15:39 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 22 Jun 2020 08:37:59 +0000 (10:37 +0200)
commitd584221e683bbd173738603b83a315f27d27d043
tree268ed0e7145c1c701aa82b4c443bb65793007fc3
parent6f4aa35744f69ed9b0bf5a736c9ca9b44bc1dcea
leds: lm3533: fix use-after-free on unbind

Several MFD child drivers register their class devices directly under
the parent device. This means you cannot blindly do devres conversions
so that deregistration ends up being tied to the parent device,
something which leads to use-after-free on driver unbind when the class
device is released while still being registered.

Fixes: 50154e29e5cc ("leds: lm3533: Use devm_led_classdev_register")
Cc: stable <stable@vger.kernel.org> # 4.6
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-lm3533.c