[IndVarSimplify] Don't replace IV user with unsafe loop-invariant (PR45360)
authorRoman Lebedev <lebedev.ri@gmail.com>
Tue, 23 Jun 2020 10:52:21 +0000 (13:52 +0300)
committerRoman Lebedev <lebedev.ri@gmail.com>
Tue, 23 Jun 2020 10:53:15 +0000 (13:53 +0300)
commitd57e9aca0137dd088825abd80ea4a616e49d17ed
tree4b78752a4ade916547df646f35fbacbf9203740e
parentf3f016dbaa0db9ae0f6706ccc6dee26770ac4d33
[IndVarSimplify] Don't replace IV user with unsafe loop-invariant (PR45360)

Summary:
As [[ https://bugs.llvm.org/show_bug.cgi?id=45360 | PR45360 ]] reports,
with new cost-model we can sometimes end up being able to expand `udiv`/`urem` instructions.
And that exposes at least one instance of when we do that
regardless of whether or not it is safe to do.
In this particular case, it's `SimplifyIndvar::replaceIVUserWithLoopInvariant()`.

It seems to me, we simply need to check with `isSafeToExpandAt()` first.

The test isn't great. I'm not sure how to make it only run `-indvars`.

Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=45360 | PR45360 ]].

Reviewers: mkazantsev, reames, helloqirun

Reviewed By: mkazantsev

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82108
llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
llvm/test/Transforms/IndVarSimplify/X86/pr45360.ll