[Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)
authorRoman Lebedev <lebedev.ri@gmail.com>
Tue, 24 Jul 2018 08:16:50 +0000 (08:16 +0000)
committerRoman Lebedev <lebedev.ri@gmail.com>
Tue, 24 Jul 2018 08:16:50 +0000 (08:16 +0000)
commitd55661db3cba15aab1a7dcf12e13a2e000a8e051
tree1801979b5eaa8ed38c3edef2d9c0636eb351e2be
parent058c04c3ddecb4ecc81655c91b7aa0e7a5ef0ab1
[Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

Summary:
As discussed in [[ https://bugs.llvm.org/show_bug.cgi?id=38166 | PR38166 ]], we need to be able to distinqush whether the cast
we are visiting is actually a cast, or part of an `ExplicitCast`.
There are at least four ways to get there:
1. Introduce a new `CastKind`, and use it instead of `IntegralCast` if we are in `ExplicitCast`.

   Would work, but does not scale - what if we will need more of these cast kinds?
2. Introduce a flag in `CastExprBits`, whether this cast is part of `ExplicitCast` or not.

   Would work, but it isn't immediately clear where it needs to be set.
2. Fix `ScalarExprEmitter::VisitCastExpr()` to visit these `NoOp` casts.

   As pointed out by @rsmith, CodeGenFunction::EmitMaterializeTemporaryExpr calls

   skipRValueSubobjectAdjustments, which steps over the CK_NoOp cast`,

   which explains why we currently don't visit those.

   This is probably impossible, as @efriedma points out, that is intentional as per `[class.temporary]` in the standard
3. And the simplest one, just record which NoOp casts we skip.

   It just kinda works as-is afterwards.

But, the approach with a flag is the least intrusive one, and is probably the best one overall.

Reviewers: rsmith, rjmccall, majnemer, efriedma

Reviewed By: rsmith

Subscribers: cfe-commits, aaron.ballman, vsk, llvm-commits, rsmith

Differential Revision: https://reviews.llvm.org/D49508

llvm-svn: 337815
clang/include/clang/AST/Expr.h
clang/include/clang/AST/Stmt.h
clang/lib/AST/ASTDumper.cpp
clang/lib/Sema/SemaCast.cpp
clang/lib/Serialization/ASTReaderStmt.cpp
clang/lib/Serialization/ASTWriterDecl.cpp
clang/lib/Serialization/ASTWriterStmt.cpp
clang/test/PCH/cxx_exprs.cpp
clang/test/Sema/multistep-explicit-cast.c [new file with mode: 0644]
clang/test/SemaCXX/multistep-explicit-cast.cpp [new file with mode: 0644]
clang/test/SemaOpenCL/multistep-explicit-cast.cl [new file with mode: 0644]